Bug 31857

Summary: TpDebugSender should fix invalid UTF-8 strings
Product: Telepathy Reporter: Jonny Lamb <jonny.lamb>
Component: tp-glibAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED MOVED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: love
Version: git master   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Jonny Lamb 2010-11-23 02:08:43 UTC
A CM can call tp_debug_sender_add_message with an invalid UTF-8 string and, assuming the debugger is disabled, the string will sit in the debugger until GetMessages() is called, when it will make the CM be disconnected from the bus.

We should:

... in the short term, only allow valid UTF-8 strings to be added to the debugger.

... in the long term, have some function (ideally in GLib, but yeah) to fix up bad strings munging the badness out of them. Apparently pidgin has a good function for task.
Comment 1 Simon McVittie 2013-09-12 18:42:53 UTC
We now have tp_utf8_make_valid() which is basically that function. This shouldn't be rocket science now.
Comment 2 GitLab Migration User 2019-12-03 20:37:25 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-glib/issues/49.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.