Bug 31725

Summary:	use TpBaseChannel for Idle's channels
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	idle	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	trivial
Priority:	medium	Keywords:	love, patch
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:	review+
i915 platform:		i915 features:

Description Simon McVittie 2010-11-18 06:00:32 UTC

telepathy-glib has had TpBaseChannel since 0.11.14. It'd be good to use it in Idle.

Comment 1 Will Thompson 2012-07-19 11:16:12 UTC

whoops http://cgit.collabora.com/git/user/wjt/telepathy-idle/log/?h=base-channel

Comment 2 Simon McVittie 2012-07-19 17:59:45 UTC

+ const gchar *recipient = tp_handle_inspect (
+ tp_base_connection_get_handles (conn, TP_HANDLE_TYPE_CONTACT),
+ tp_base_channel_get_target_handle (base));

I'm a bit surprised we don't have tp_base_channel_get_target_id(), but indeed, we don't.

This looks good to merge, but leave the bug open (assuming room channels still need the same treatment).

Comment 3 Will Thompson 2012-08-01 10:11:51 UTC

(In reply to comment #2)
> This looks good to merge, but leave the bug open (assuming room channels still
> need the same treatment).

They don't.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.