Bug 31680

Summary:	g_error() on failed dbus name acquisition looks like a core dump to automated test suites
Product:	Telepathy	Reporter:	Vivek Dasmohapatra <vivek>
Component:	mission-control	Assignee:	Vivek Dasmohapatra <vivek>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	5.6
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/vivek/telepathy-mission-control;a=shortlog;h=refs/heads/keep-calm-but-do-not-carry-on
Whiteboard:	review+
i915 platform:		i915 features:

Description Vivek Dasmohapatra 2010-11-17 06:14:33 UTC

Downgrading to a g_warning() allows us to fall through to the 
exit(1), and reduces the number of misreported core dumps.
(and allows us to deal with _real_ core dumps instead of 
explaining why these are Ok, really, honest)

Comment 1 Simon McVittie 2010-11-17 06:19:49 UTC

r+ for the single commit at the tip of that branch - I assume the rest have already gone in?

Comment 2 Vivek Dasmohapatra 2010-11-17 07:40:41 UTC

I branched from 5.6 so I assume so, unless something weird is going on.

Comment 3 Simon McVittie 2010-11-23 08:18:13 UTC

Fixed in 5.7.0. Does not appear to have been changed in 5.6 - is this deliberate?

Comment 4 Vivek Dasmohapatra 2010-11-23 08:27:39 UTC

Yes - not getting any false +ves from 5.6.x now that 5.7.x is out.

Comment 5 Simon McVittie 2010-11-23 08:38:10 UTC

Fixed in 5.7.0, WONTFIX in 5.6, then.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.