| Summary: | telepathy-yell: temporary submodule for draft Call implementations | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | tp-glib | Assignee: | Jonny Lamb <jonny.lamb> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/jonny/telepathy-yell.git;a=summary | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Simon McVittie
2010-10-29 04:14:08 UTC
COPYING talks about librtcom-telepathy-glib, which is wrong, and mentions a Nokia copyright, which is probably wrong. > AM_INIT_AUTOMAKE([1.9 -Wall -Wno-portability foreign]) This one goes to 11 (or should). We never test it with 1.9 anyway, and it wouldn't work (you used AM_SILENT_RULES unconditionally). You'll need to change autogen.sh too. > PKG_CHECK_MODULES(GLIB, [glib-2.0 >= 2.25.16, gobject-2.0 >= 2.25.16]) I'd be inclined to say 2.26 for clarity. > PKG_CHECK_MODULES(TP_GLIB, [telepathy-glib >= 0.7.18]) Do we really interop with such an old version? I'd be inclined to say 0.12 if it works, or whatever version is actually needed otherwise. > if ENABLE_SHARED_LIBRARY > lib_LTLIBRARIES = libtelepathy-yell.la I think this should have -release in its LDFLAGS in the shared case, leading to libtelepathy-yell.la and libtelepathy-yell-0.1.2.so or something. Indeed, we could do something like this: # static-only embedding ./configure # yields libtelepathy-yell-gabble-0.11.4.so, via # libtool --mode=link -release $(LIBRARY_SUFFIX) ... ./configure --enable-library-suffix=gabble-0.11.4 (In reply to comment #1) > COPYING talks about librtcom-telepathy-glib, which is wrong, and mentions a > Nokia copyright, which is probably wrong. Fixed. > > AM_INIT_AUTOMAKE([1.9 -Wall -Wno-portability foreign]) > > This one goes to 11 (or should). We never test it with 1.9 anyway, and it > wouldn't work (you used AM_SILENT_RULES unconditionally). You'll need to change > autogen.sh too. Fixed. > > PKG_CHECK_MODULES(GLIB, [glib-2.0 >= 2.25.16, gobject-2.0 >= 2.25.16]) > > I'd be inclined to say 2.26 for clarity. Done. > > PKG_CHECK_MODULES(TP_GLIB, [telepathy-glib >= 0.7.18]) > > Do we really interop with such an old version? I'd be inclined to say 0.12 if > it works, or whatever version is actually needed otherwise. Done. > > if ENABLE_SHARED_LIBRARY > > lib_LTLIBRARIES = libtelepathy-yell.la > > I think this should have -release in its LDFLAGS in the shared case, leading to > libtelepathy-yell.la and libtelepathy-yell-0.1.2.so or something. > > Indeed, we could do something like this: > > # static-only embedding > ./configure > > # yields libtelepathy-yell-gabble-0.11.4.so, via > # libtool --mode=link -release $(LIBRARY_SUFFIX) ... > ./configure --enable-library-suffix=gabble-0.11.4 Okay, I implemented this. All done, thanks. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.