Bug 31135

Summary:	Add a 'Removed' signal to Call.Content?
Product:	Telepathy	Reporter:	Jonathon Jongsma <jonathon>
Component:	tp-spec	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/jonny/telepathy-spec.git;a=shortlog;h=refs/heads/content-removed
Whiteboard:	Call
i915 platform:		i915 features:

Description Jonathon Jongsma 2010-10-26 09:43:37 UTC

The relationship between a Call channel and a Call.Content object is somewhat comparable to the relationship between Connection and Channel.  

- Channels are created with a method on Connection (e.g. CreateChannel(), etc.).  Call.Content objects are created by a method on Call (AddContent()).
- Channels are closed by a method on itself (Close()), Call.Content objects are removed by a method on itself (Remove())
- Changes in the existing Channel objects are communicated by signals on the Connection Object (NewChannels, ChannelClosed).  Changes in Call.Content objects are communicated with signals on the Call object (ContentAdded, ContentRemoved)

The one difference between this analogy is that the Channel object itself also has a 'Closed' signal, but the Call.Content object does not have a 'Removed' signal.  If this were added, I think it would improve the API consistency.

Comment 1 Jonny Lamb 2010-10-26 09:51:03 UTC

Check out my branch.

Comment 2 Jonathon Jongsma 2010-10-26 09:57:14 UTC

Patch looks good to me.  And there seemed to concensus on the idea in IRC.

Comment 3 Jonny Lamb 2010-10-26 10:46:37 UTC

Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.