Bug 30950

Summary: Advertise Messages' immutable properties as such
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: gabbleAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium CC: guillaume.desmottes
Version: git masterKeywords: patch
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=shortlog;h=refs/heads/message-properties
i915 platform: i915 features:
Bug Depends on: 30949    
Bug Blocks:    

Description Simon McVittie 2010-10-18 04:21:54 UTC
tp-spec 0.21.2 clarified that MessagePartSupportFlags, SupportedContentTypes and DeliveryReportingSupport are immutable.

As such, they should be in NewChannels.

Due to Bug #30949, DeliveryReportingSupport won't work reliably until we depend on telepathy-glib 0.13.3, so the tests don't test its value, only that it exists. There is a FIXME comment for that.
Comment 1 Guillaume Desmottes 2010-10-18 07:01:12 UTC
looks good
Comment 2 Simon McVittie 2010-10-28 09:20:14 UTC
Thanks, fixed in git for 0.11.0. Here's a trivial branch to bring back the missing (bit of) test.
Comment 3 Guillaume Desmottes 2010-10-29 00:47:36 UTC
Comment 4 Simon McVittie 2010-10-29 07:48:50 UTC
0.11.0, not worth backporting IMO

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.