Bug 30223

Summary:	telepathy-qt4's codegen doesn't deal with tp:external-type properly.
Product:	Telepathy	Reporter:	Will Thompson <will>
Component:	tp-qt	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	git master
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/bari/telepathy-qt4.git;a=shortlog;h=refs/heads/external-type
Whiteboard:
i915 platform:		i915 features:

Description Will Thompson 2010-09-16 03:57:06 UTC

It works for basic types, but not for any type where a new C++ type is needed.

Here's a branch where I started looking into it, with a new method added to the example extension which hits the breakage: <http://git.collabora.co.uk/?p=user/wjt/telepathy-qt4.git;a=shortlog;h=refs/heads/external-type>

I got lost in a tangled mess of trying to figure out which variables are meant to hold Type_Name, which are meant to hold TypeName, and which are meant to hold Namespace::TypeName, and gave up.

Comment 1 Marco Barisione 2010-10-11 04:15:18 UTC

Here's my branch with Will's 2 original patches (to improve error reporting and to test external types) and my 2 patches to fix the bug.

Comment 2 Olli Salli 2010-10-18 08:43:25 UTC

The patch seems to do its job admirably. Merged to master. Will be in 0.3.13 (although it doesn't affect the library proper in any way, just anybody using our tools!).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.