Bug 30207

Summary: Doesn't stop listening to MCE state change notifications after stream errors
Product: Telepathy Reporter: Will Thompson <will>
Component: gabbleAssignee: Will Thompson <will>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: 0.10   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=shortlog;h=refs/heads/slacker-crash
Whiteboard: review+
i915 platform: i915 features:

Description Will Thompson 2010-09-15 02:42:13 UTC
Gabble only stops listening to MCE if the connection is cleanly disconnected. If it encounters a stream error, the next MCE state change yields the following crash:

3  IA__g_assertion_message_expr (..., expr=0xf91e8 "GABBLE_IS_CONNECTION (conn)")
4  _gabble_connection_send_with_reply (...) at connection.c:1426
5  conn_slacker_send_command (conn=0x165008) at conn-slacker.c:41
[ emission of GabbleSlacker:inactivity-changed ]
11  slacker_message_filter (message=0x1b9a78) at slacker.c:133

Patch incoming.
Comment 1 Simon McVittie 2010-09-15 03:09:28 UTC
r+, good catch.
Comment 2 Will Thompson 2010-09-15 03:36:16 UTC
Merged, thanks; will be in 0.9.19 (which might turn out to be 0.10.0?)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.