Bug 29688

Summary:	[bisected glsl2]piglit glslparsertest_CorrectFull.frag fails
Product:	Mesa	Reporter:	fangxun <xunx.fang>
Component:	Mesa core	Assignee:	Eric Anholt <eric>
Status:	VERIFIED DUPLICATE	QA Contact:
Severity:	major
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description fangxun 2010-08-20 00:41:48 UTC

System Environment:
--------------------------
Arch    x86_64
Platform    piketon
Libdrm:         (master)2.4.21-16-gb61e81a191d3a5c269c5f7c40199aebc9ebc034c
Mesa:           (master)d442a01ac14382d83cdaac87d2832315ceb3e963
Xserver:         (master)xorg-server-1.8.99.906
Xf86_video_intel:  (master)2.12.0-66-g19c48d3b3f33582baa87a9b3a9189e320e4cea45


Bug detailed description:
-------------------------
glslparsertest_CorrectFull.frag fails with error messages:
glslparsertest: ir_validate.cpp:382: void check_node_type(ir_instruction*, void*): Assertion `ir->type != glsl_type::error_type' failed.
Aborted

Bisect find 2f4fe151681a6f6afe1d452eece6cf4144f44e49 is first bad commit.
commit 2f4fe151681a6f6afe1d452eece6cf4144f44e49
Author: Eric Anholt <eric@anholt.net>
Date:   Tue Aug 10 13:06:49 2010 -0700

    glsl2: Move the common optimization passes to a helper function.

    These are passes that we expect all codegen to be happy with.  The
    other lowering passes for Mesa IR are moved to the Mesa IR generator.


Reproduce steps:
----------------
1.xinit& 
2.glslparsertest CorrectFull.frag pass

Comment 1 Eric Anholt 2010-08-30 11:25:13 UTC


*** This bug has been marked as a duplicate of bug 29573 ***

Comment 2 Gordon Jin 2010-09-18 17:40:43 UTC

It passes with today's mesa master, but not cherry-picked to 7.9 yet.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.