Bug 29145

Summary:	AccountSet::accountRemoved is emitted for newly-created non-matching accounts
Product:	Telepathy	Reporter:	Will Thompson <will>
Component:	tp-qt	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	git master
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/wjt/telepathy-qt4.git;a=commitdiff;h=refs/heads/new-account-removed
Whiteboard:	r+
i915 platform:		i915 features:

Description Will Thompson 2010-07-19 06:00:56 UTC

If you create an account set, and then create a new account which doesn't match the set's filter, ::accountRemoved() is emitted by the set for the new account (even though it was never in the set).

Patch to follow.

Comment 1 Will Thompson 2010-07-19 06:02:14 UTC

Here is a patch.

I didn't add a test case, it looked like it would be a pain. But there should really be some tests for the signals on AccountSet.

Comment 2 Andre Moreira Magalhaes 2010-07-19 06:21:01 UTC

Looks good.

Comment 3 Andre Moreira Magalhaes 2010-07-29 23:52:46 UTC

Merged upstream. It will be in next release 0.3.8

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.