Bug 29111

Summary: --disable-xv is broken
Product: xorg Reporter: Michael Olbrich <m.olbrich>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium CC: kibi
Version: gitKeywords: patch
Hardware: Other   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
fix build without xv none

Description Michael Olbrich 2010-07-16 07:07:49 UTC
when compiling with --disable-xv I get:

  CCLD   Xorg
./.libs/libxorg.a(xf86Crtc.o): In function `xf86_crtc_clip_video_helper':
xf86Crtc.c:(.text+0x87fc): undefined reference to `xf86XVClipVideoHelper'
collect2: ld returned 1 exit status
make[5]: *** [Xorg] Error 1

There is probably some ifdef stuff missing, but I don't really understand the code, so I can't provide a patch for this.
Comment 1 Julien Cristau 2010-07-16 07:23:57 UTC
Created attachment 37129 [details] [review]
fix build without xv
Comment 2 Michael Olbrich 2010-07-16 07:53:20 UTC
I can compile the xserver with this patch. However it crashes on startup:

[3694698.999] (==) intel(0): Backing store disabled
[3694698.999] (==) intel(0): Silken mouse enabled
[3694699.001] (II) intel(0): Initializing HW Cursor
[3694699.601] (II) intel(0): RandR 1.2 enabled, ignore the following RandR disabled message.

Without XV I get a segfault here. No usefull backtrace so far (just some '???').

[3694699.602] (II) intel(0): Set up overlay video
[3694699.602] (II) intel(0): direct rendering: DRI2 Enabled

This comes next _with_ XV. So I guess something goes wrong while setting up overlay video. I have no idea if the problem is in the xserver or the intel driver (xf86-video-intel-2.12.0).
Comment 3 Julien Cristau 2010-07-16 08:25:44 UTC
> --- Comment #2 from Michael Olbrich <m.olbrich@pengutronix.de> 2010-07-16 07:53:20 PDT ---
> This comes next _with_ XV. So I guess something goes wrong while setting up
> overlay video. I have no idea if the problem is in the xserver or the intel
> driver (xf86-video-intel-2.12.0).
> 
Looks like the intel driver assumes XV is enabled.  We're using fbdev
on the XV-disabled server, and that works fine afaik.
Comment 4 Cyril Brulebois 2011-06-05 08:33:49 UTC
Indeed. Can we get that patch merged at some point? I just stumbled upon that build failure while playing with random build options.

It has my:
Tested-by: Cyril Brulebois <kibi@debian.org>
Reviewed-by: Cyril Brulebois <kibi@debian.org>
Comment 5 Jeremy Huddleston Sequoia 2011-10-09 17:08:35 UTC
Thanks.  It's now in my "for-keith" branch which will be in a [PULL] request 
soon.
Marking as fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.