Summary: | Make rationale blocks collapsible. | ||
---|---|---|---|
Product: | Telepathy | Reporter: | Will Thompson <will> |
Component: | tp-spec | Assignee: | Will Thompson <will> |
Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
Severity: | normal | ||
Priority: | medium | Keywords: | patch |
Version: | git master | ||
Hardware: | Other | ||
OS: | All | ||
URL: | http://git.collabora.co.uk/?p=user/wjt/telepathy-spec-wjt.git;a=shortlog;h=refs/heads/collapsable-rationale | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
Will Thompson
2010-06-21 11:46:46 UTC
I think this is ready for review. I added little triangles. http://people.freedesktop.org/~wjt/telepathy-spec-collapsable_rationale/spec/Channel_Interface_Messages.html Olivier pointed out: Tester | wjt: if you're gonna hide rationales in the normal case.. someone should probably review them to make sure they're really rationales.. as an example.. look at MessageReceived (which its really a warning to implementors) wjt | Tester: that's a good point. Tester | maybe there should be a <warning> tag/box also wjt | i'm going through the messages interface anyway at the moment... and this double signal emission thing just suggests that we should require Messages and move on :) Tester | and get rid of Text ? So in my branch over at bug 28613 I made sure that the stuff hidden in rationales in Messages is moved out of them. I like this in principle, but shipping jQuery.min.js without source code seems undesirable. I don't want to have to repack the telepathy-spec source distribution for it to be acceptable in Debian :-P Possible solutions include: * use a snapshot of the non-minified version and upload the whole thing * use a snapshot of the non-minified version and minify it with yui-compressor if available * copy it from libjquery-js at build time, if installed (In reply to comment #2) > * use a snapshot of the non-minified version and upload the whole thing That's the route I chose. commit 5ff575c1d8ab75a2aa30ca772f8cf94d62d03eb0 Merge: 7e2dffc 67fb366 Author: Will Thompson <will.thompson@collabora.co.uk> Date: Wed Jun 30 15:28:58 2010 +0100 Merge branch 'collapsable-rationale' See <https://bugs.freedesktop.org/show_bug.cgi?id=28653>. Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.