Bug 28247

Summary:	Properly use is_secure argument in wocky_auth_registry_start_auth_async.
Product:	Wocky	Reporter:	Eitan Isaacson <eitan.isaacson>
Component:	General	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/eitan/wocky.git;a=shortlog;h=refs/heads/auth-is-secure
Whiteboard:	r+
i915 platform:		i915 features:

Description Eitan Isaacson 2010-05-25 12:17:10 UTC

It was hard-coded to TRUE, even if this was just a placeholder, TRUE is a really really bad choice :)

Comment 1 Eitan Isaacson 2010-05-25 12:24:05 UTC

Can't think of a test case for this without subclassing WockyAuthRegistry, which seems like overkill. Could the test live in Gabble?

Comment 2 Will Thompson 2010-06-03 13:37:50 UTC

(In reply to comment #1)
> Can't think of a test case for this without subclassing WockyAuthRegistry,
> which seems like overkill. Could the test live in Gabble?

That'd be okayish with me — sub-ideal, but it looks pretty straightforward and right, so...

Comment 3 Eitan Isaacson 2010-06-08 08:19:13 UTC

Merged, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.