Bug 28203

Summary:	Group.AddMembers, Group.RemoveMembers should succeed if no-op
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	tp-glib	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	will
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
URL:	https://bugs.freedesktop.org/show_bug.cgi?id=28203#c0
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	28200

Description Simon McVittie 2010-05-21 05:47:27 UTC

Group.AddMembers for contacts who are already full members should succeed, even if the CAN_ADD flag is not set.

Group.RemoveMembers[WithReason] for contacts who are neither members, local-pending nor remote-pending should succeed, regardless.

Branch for 0.10 (just changes the behaviour of TpGroupMixin):

http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/010-group-and-contact-list

Branch for 0.11 (also adds tests for the contact list example, and alters its behaviour to resemble the new ContactList API more closely):

http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/test-contact-list-cm

This could easily be backported all the way to 0.8, if you want it to be.

Comment 1 Will Thompson 2010-05-21 06:51:09 UTC

(In reply to comment #0)
> Branch for 0.10 (just changes the behaviour of TpGroupMixin):
> 
> http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/010-group-and-contact-list

++ for this one.

Comment 2 Will Thompson 2010-05-21 08:05:02 UTC

(In reply to comment #0)
> Branch for 0.11 (also adds tests for the contact list example, and alters its
> behaviour to resemble the new ContactList API more closely):
> 
> http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/test-contact-list-cm

Assuming the tests are right, ++

Comment 3 Simon McVittie 2010-05-21 08:32:22 UTC

Fixed in git, will be in 0.10.6 and 0.11.6.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.