Bug 27881

Summary: Should use TpSimpleObserver
Product: Telepathy Reporter: Guillaume Desmottes <guillaume.desmottes>
Component: loggerAssignee: Guillaume Desmottes <guillaume.desmottes>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: enhancement    
Priority: medium Keywords: patch
Version: git master   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/cassidy/telepathy-logger;a=shortlog;h=refs/heads/observer
Whiteboard:
i915 platform: i915 features:
Bug Depends on: 27871    
Bug Blocks:    

Description Guillaume Desmottes 2010-04-29 00:37:07 UTC 
Bug #27871 adds TpSimpleObserver to tp-glib. Tp-logger should use it instead of its own Observer implementation.
Comment 1 Guillaume Desmottes 2010-05-20 03:20:33 UTC 
I'm going to use TpBaseClient actually.
Comment 3 Simon McVittie 2010-05-31 05:54:36 UTC 
Looks good, but I'd prefer a couple of additional changes:

> error:
> ...
> +  DEBUG ("Returning from observe channels on error condition. "
> +      "Unable to log the channel");
> +
> +  tp_observe_channels_context_accept (context);

What errors can occur? It seems more correct to use tp_observe_channels_context_fail() (in practice MC will log the error, then carry on regardless).

> +  if (tp_base_client_register (TP_BASE_CLIENT (observer), &error) == FALSE)

Don't compare booleans to TRUE and FALSE:

if (!tp_b_c_r (..., &error))
  {
    ...
  }
Comment 4 Guillaume Desmottes 2010-05-31 07:17:52 UTC 
done.
Comment 5 Guillaume Desmottes 2010-05-31 07:21:45 UTC 
Merged to master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.