Bug 27310

Summary:	Full MinGW support for 0.19.2
Product:	FriBidi	Reporter:	Carlo Bramini <carlo.bramix>
Component:	general	Assignee:	Behdad Esfahbod <freedesktop>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Windows (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Proposed patch

Description Carlo Bramini 2010-03-25 08:15:03 UTC

Created attachment 34433 [details] [review]
Proposed patch

Attached patch fixes the compilation on Mingw+MSYS

bin/fribidi-benchmark.c
"struct tms" mus be defined only if HAVE_SYS_TIMES_H is true.

lib/Makefile.am
The link stage generated an error because there were two incompatible options: -export-symbols and -export-symbols-regex. The second one is enought for mingw too so I removed the first one.

lib/fribidi.def
This file was wrong and there were many missing functions.
It is not used anymore with mingw but I fixed if somebody would like to build fribidi with MSVC. Do not forget to keep CR-LF line ending in this file when committing.

test/run.tests
"make check" failed because the output file CR-LF line endings since it was capture from the console. Now it detects if the platform needs to strip CR characters. You may add more platforms that have this behaviour if you find some.

Tested platforms successfully: mingw+msys, cygwin, Debian 5.0 under coLinux.

I hope it could be useful for fixing fribidi support on Windows and you could release a new version soon.

Sincerely,

Carlo Bramini.

PS: I have also fixed version 0.10.9 to work on Windows too. Would it be useful a patch for the older stable version?

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.