Bug 26643

Summary:	Need to be able to group "identical" RelayInfo relays
Product:	Telepathy	Reporter:	Olivier Crête <olivier.crete>
Component:	tp-spec	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	david.laban
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/alsuren/telepathy-spec.git;a=commitdiff;h=fb58cfe43dc22c8d8084588f803ca168b61b5c8f
Whiteboard:	Call
i915 platform:		i915 features:

Description Olivier Crête 2010-02-18 17:01:58 UTC

We've come across a new interesting case. Google gives us three relays (udp/tcp/tls) which are actually the same server. So if we connect to only one of them, we're happy. But we could also have different relays which relay into different networks. In that case, we really want to connect to all of them.
We want to be able to relay that information to libnice.

I propose adding a new optional token to the "RelayInfo" map, if two entries have the same token, then they're the same server, so connecting to only of them is enough. That will allow faster call establishment.

Comment 1 Simon McVittie 2010-11-09 09:04:07 UTC

Is this relevant to Call or have you already fixed it there?

If it's relevant to Call, please propose a concrete spec patch; your suggestion sounds reasonable.

If it's not relevant to Call, I'm inclined to say WONTFIX?

Comment 2 Olivier Crête 2010-11-09 09:16:15 UTC

It's definitely relevant to Call.

Maybe we should add a grouping member to the map in RelayInfo (ie "group" -> "X" where all elements that have X as their group are the same server). And also "Priority" field to know which one is preferable within a group (or maybe we just want to use the first one that answers).

Comment 3 Olivier Crête 2011-01-10 12:14:49 UTC

We should probably add a "server-id" field to the "RelayInfo" map. And if they are the same value, then libnice can know its actually the same server. In the case of google talk, gabble can then put the same value for all candidates generated from the same http request.

Comment 4 Olivier Crête 2011-02-11 06:55:45 UTC

To Stream.I.Media -> RelayInfo

We want to add two more properties

- unique-id: s
- priority: u

Comment 5 David Laban 2011-04-04 10:18:30 UTC

specced up at: http://git.collabora.co.uk/?p=user/alsuren/telepathy-spec.git;a=commitdiff;h=fb58cfe43dc22c8d8084588f803ca168b61b5c8f

Comment 6 Olivier Crête 2011-04-04 11:51:46 UTC

Looks ++
That said, maybe we want to make priority optional (libnice will know that like udp is better than tcp)

Comment 7 David Laban 2011-06-13 15:52:38 UTC

Considering http://cgit.collabora.com/git/user/alsuren/telepathy-spec.git/commit/?id=3de18298c0e863c9d37f303b8649d5786c9c84ef to be insta-reviewed and pushing to call.

Comment 8 David Laban 2011-07-19 12:35:08 UTC

merged to master

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.