| Summary: | Eavesdroppers don't receive method calls dispatched to just-activated services | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Will Thompson <will> |
| Component: | core | Assignee: | Havoc Pennington <hp> |
| Status: | RESOLVED FIXED | QA Contact: | John (J5) Palmieri <johnp> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
[PATCH 1/2] Move dispatching to destination to bus_dispatch_matches()
[PATCH 2/2] Dispatch post-activation messages to anyone interested |
||
|
Description
Will Thompson
2010-02-04 08:32:18 UTC
Created attachment 33094 [details] [review] [PATCH 1/2] Move dispatching to destination to bus_dispatch_matches() Created attachment 33095 [details] [review] [PATCH 2/2] Dispatch post-activation messages to anyone interested Previously, if a method call activated a service, it would only be delivered to that service, and not to other services with match rules which should match. This patch replaces the improperly-duplicated dispatch code in activation.c with a call back into the normal dispatch code, fixing this bug (fd.o#26427). (Additionally, were one to service-activate a service that doesn't understand file descriptors with a message containing a file descriptor, the previous code would send it anyway, and the service's dbus library would blow up. This is also fixed here, since the normal dispatch code checks this correctly.) I've fixed this, but haven't written a regression test, I'm afraid. Branch against master at <http://git.collabora.co.uk/?p=user/wjt/dbus.git;a=shortlog;h=refs/heads/where-did-my-method-calls-go> and backported to 1.2 at <http://git.collabora.co.uk/?p=user/wjt/dbus.git;a=shortlog;h=refs/heads/where-did-my-method-calls-go-1.2>. Comment on attachment 33094 [details] [review] [PATCH 1/2] Move dispatching to destination to bus_dispatch_matches() After re-familiarizing myself with the dispatching logic, this first patch looks right to me. Comment on attachment 33095 [details] [review] [PATCH 2/2] Dispatch post-activation messages to anyone interested Looks good, thanks! Merged to master and dbus-1.2, thanks for the review! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.