Bug 26384

Summary:	Missing DBus properties on Media.StreamHandler
Product:	Telepathy	Reporter:	Mikhail Zabaluev <mikhail.zabaluev>
Component:	rakia	Assignee:	Mikhail Zabaluev <mikhail.zabaluev>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	minor
Priority:	high	CC:	smcv
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/zabaluev/telepathy-sofiasip.git;a=shortlog;h=refs/heads/stream-properties
Whiteboard:	review+
i915 platform:		i915 features:

Description Mikhail Zabaluev 2010-02-02 06:00:03 UTC

The implementation of org.freedesktop.Telepathy.Media.StreamHandler does not provide any DBus properties for NAT traversal in accordance with the specification.
This does not prevent things from working with libtelepathy-farsight and stream-engine, because they also check for legacy Telepathy properties on the channel.

Comment 1 Mikhail Zabaluev 2010-02-02 06:01:09 UTC

Branch with the implemeentation:
http://git.collabora.co.uk/?p=user/zabaluev/telepathy-sofiasip.git;a=shortlog;h=refs/heads/stream-properties

Comment 2 Mikhail Zabaluev 2010-02-08 06:45:42 UTC

Please review

Comment 3 Mikhail Zabaluev 2010-02-08 09:41:19 UTC

Pushed a reimplementation with TpDBusPropertiesMixin.

Comment 4 Simon McVittie 2010-02-08 11:24:46 UTC

Re-reviewing.

(Please put branches in the bugzilla URL field in future, as I've done here)

Comment 5 Simon McVittie 2010-02-08 11:27:14 UTC

Thanks, review+

Comment 6 Mikhail Zabaluev 2010-02-16 00:25:45 UTC

Tagged as telepathy-sofiasip-0.6.0, pending a proper fd.o release Real Soon Now.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.