Bug 26303

This is using D-Bus version 1.2.16.

Some Solaris users are complaining that dbus-daemon is crashing on occasion in _dbus_loop_quit, when it is being passed in a NULL pointer.  This is happening with the dbus-daemon that is started with the new GDM used when GDM presents the login GUI screen to the user.

See here for more information:

  http://defect.opensolaris.org/bz/show_bug.cgi?id=13710

Looking at the D-Bus code it looks like _dbus_loop_quit only gets called in SIGTERM.  It seems the crash is happening when _dbus_loop_quit is being called with a NULL pointer, which seems odd.  The _dbus_loop quit does the following:

  _dbus_assert (loop->depth > 0);
 
  loop->depth -= 1;

So it would make sense that it would crash if passed a NULL pointer.

Note that the new GDM does kill D-Bus with a SIGTERM.  However, I wonder if it is possible that it might be receiving multiple SIGTERM signals or if it is receiving a SIGTERM when it is already in the process of shutting down.  This might explain why a NULL pointer is being passed into the _dbus_loop_quit() function.  Is it possible that there is some odd race condition here?

Perhaps the fix would be to simply d_get_loop (context) returns NULL, or otherwise better handle a NULL so it doesn't crash.