Bug 26257

I think we do: we delete Calls from conn when the Channels are invalidated at least.

Having a test which checks with the garbage collector that no instances of Call, StreamedMediaChannel, Connection etc exist at relevant points would be nice before I close this bug.

Pushed fixes and tests to [1]. The last commit "optionally use objgraph to help debug..." is optional because it uses a module that's available from pypi but not apt. It shows how I debugged the leaks in the first place, so I thought I should include it.

[1] http://git.collabora.co.uk/?p=user/alsuren/telepathy-fargo.git;a=shortlog;h=refs/heads/leaks

> \ No newline at end of file

No thanks. (But consider this change insta-reviewed :-P)

> +        if isinstance(obj, class_) and not isinstance(obj, weakref.ProxyType):

Slightly terrifying, but appears necessary... :-/

(I generally prefer weakref.ref, for this sort of reason - also, "explicit is better than implicit".)

> +from twisted.internet import reactor

Is it strictly necessary to add this to from_xmpp.py? It doesn't seem to be used. If it's being imported for its side-effects (what are they?), please comment that.

> +def gc_get_instances(class_):

If it's deliberate that class_ can actually be a tuple of classes, please add a docstring that says so.

The optional commit is fine too, since it only triggers when we're about to fail and is robust against the module's absence.

I made a branch to ban the use of IQs. See your #telepathy logs for details of why (sorry: got to dash)

http://git.collabora.co.uk/?p=user/alsuren/telepathy-fargo.git;a=shortlog;h=refs/heads/ban-twisted-iq-class

Take particular note of the log message "Should probably file a bug for cancelling the call if we get an iq error or timeout."

This was also brainstormed by me to #telepathy. Comments on this bug.

I'm pretty convinced that this is fixed now, thanks to 26099.