| Summary: | Implement EnsureChannel for Call channels. | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Mike Ruprecht <cmaiku> |
| Component: | gabble | Assignee: | Sjoerd Simons <sjoerd> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/maiku/telepathy-gabble.git;a=shortlog;h=refs/heads/implement-ensure | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Mike Ruprecht
2010-01-18 18:40:29 UTC
Seems bugzilla ate my comments: Basically when ensuring a channle you need to also check the list of pending call channels and add the reqest token to the MCR if applicable. Updated the branch per your review comments. I didn't get to testing this yet. The ChannelDispatcher kept eating my EnsureChannel request. Feel free to look over it though. I can spend some more time to test it correctly tomorrow. THe code looks good to me, but some ensurance that it works would be nice :).. Also tests! Updated the branch per your review comments. (I did find a few things wrong. oops. yay for testing) Looks ok, merging. Note that once we delay the media channel untill we got the disco caps of the remote party we can deterministically test the case where we ensure a channel that is internally in pending state |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.