Bug 26106

Summary: New Call Spec: Handle additional contents being added from both the local and remote ends.
Product: Telepathy Reporter: Mike Ruprecht <cmaiku>
Component: gabbleAssignee: Sjoerd Simons <sjoerd>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/maiku/telepathy-gabble.git;a=shortlog;h=refs/heads/handle-new-content
Whiteboard:
i915 platform: i915 features:

Description Mike Ruprecht 2010-01-18 17:01:43 UTC
See summary
Comment 1 Sjoerd Simons 2010-01-20 04:41:01 UTC
* (sending == TRUE) == (exists == FALSE ||

heh :) sending == (!exists || would be fine :p

In your commits, keep in mind that first line is subject,body is afterwards. (7eac0028 is a bit strange in this respect). Also break your lines at around 70 chars :)

7eac00289b23:

* Why do we set streams we created to sending automagically on accept?
* why doesn't the stream have a utility function to get our local state? Seems content knows more about the stream implementation then it should.

 
32f28 and seems to be revert by 4bb17? please squash those
Comment 2 Mike Ruprecht 2010-01-20 14:03:18 UTC
Updated the branch per your review comments.
Comment 3 Sjoerd Simons 2010-01-22 06:41:14 UTC
look ok, merging

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.