Bug 25988

Summary:	Wocky doesn't handle final data with success
Product:	Wocky	Reporter:	Sjoerd Simons <sjoerd>
Component:	General	Assignee:	Dafydd Harries <dafydd.harries>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	0.8
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/sjoerd/wocky.git;a=shortlog;h=refs/heads/auth-data-with-success
Whiteboard:
i915 platform:		i915 features:

Description Sjoerd Simons 2010-01-11 06:05:25 UTC

Since 3920bis it's allowed to do the final sasl data as part of the success stanza instead of doing an extra roundtrip (challenge with final data, empty response). At the moment wocky doesn't handle this, fixed in my branch (see URL). This branch also refactors the SaslHandler stuff slightly such that it's easier to implement a trivial handler and such that handlers for mechanisms in which the server sends the final data don't have to care wether it will be received in a  <success /> or a <challenge />

Comment 1 Dafydd Harries 2010-01-26 12:52:23 UTC

The branch is a whole is ok. Generalizing extracting the data from the SASL stanzas is definitely a good thing, as is separating the function for the initial data. I'm not really convinced by the "handle_auth_data" name, but I don't have a better suggestion.

The WockySaslHandlerIface documentation is now out of date. Please update it.

Comment 2 Sjoerd Simons 2010-01-27 07:03:15 UTC

Documentation updated as per your suggestion (reviewed by wjt). the method name is indeed not great, but i also failed to come up with something better..

Merged all the way, thanks for the review

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.