Bug 25978

Summary:	Modifier for keyboards lacking right ctrl
Product:	xkeyboard-config	Reporter:	Alexander Kahl <e-user>
Component:	General	Assignee:	xkb
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	Keywords:	NEEDINFO
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch to add modifiers for menu key Patch incorporating the proposed change into existing ctrl group

Description Alexander Kahl 2010-01-10 04:03:52 UTC

I'm in possession of a Lenovo Ideapad S10e and its designers seem to have had
the brilliant idea of skipping the right control key in favor of a useless menu
key which is particularly bad for e.g. emacs users like me. 
Right now, the predefined xkeyboard-config options don't provide a customization
to cope with the situation and I bet there are other laptop models affected.

I've created a patch to map right control to the menu key but for a non-dev
version of xkeyboard-config - right now I update the affected files each time an
update comes in from my distro so I'd really like to see my changes going
upstream as I believe others would benefit from doing so.

Please tell me against which version to patch for the patch to be accepted, if
possible at all.
http://www.freedesktop.org/wiki/Software/XKeyboardConfig/Rules doesn't seem to
cover that (or I'm blind).

Comment 1 Sergey V. Udaltsov 2010-01-18 16:46:47 UTC

http://www.freedesktop.org/wiki/Software/XKeyboardConfig/Development

Please create a patch against the master branch in git

Comment 2 Alexander Kahl 2010-01-20 12:03:12 UTC

Created attachment 32748 [details] [review]
patch to add modifiers for menu key

Here you go. Hope everything is OK.

Comment 3 Sergey V. Udaltsov 2010-01-28 16:30:21 UTC

That patch is almost ok. But I do not like the idea to create 'menu' group just for this option. Could we extend altwin group?

Comment 4 Alexander Kahl 2010-01-29 04:05:27 UTC

I don't think altwin would be the appropriate place for a modifier targeting menu and ctrl - but neither altwin nor the ctrl group allow multiple selections right now, e.g. I am using a modifiers from either group (alt and meta on alt, swap ctrl and capslock) in my current layout and would suffer from having to dump one of them.
The additional group seems appropriate because the modifier doesn't contradict with the existing ones but rather complement one another.

Comment 5 Alexander Kahl 2010-02-10 00:25:32 UTC

Ping

Comment 6 Sergey V. Udaltsov 2010-03-26 04:39:43 UTC

Sorry for delay.
Actually, I think it would be reasonable to make 'ctrl' group multisel. That way your option would fit into it perfectly. What do you think?

Comment 7 Alexander Kahl 2010-06-07 03:26:11 UTC

Created attachment 36095 [details] [review]
Patch incorporating the proposed change into existing ctrl group

Comment 8 Alexander Kahl 2010-06-07 03:29:05 UTC

(In reply to comment #6)
> Sorry for delay.
> Actually, I think it would be reasonable to make 'ctrl' group multisel. That
> way your option would fit into it perfectly. What do you think?

Hi Sergey,

I'm also sorry for the long delay, $DAYJOB, you know ;)
Your suggestion is really good IMO, the new patch reflects that and has been made against an updated version of git master.

Comment 9 Sergey V. Udaltsov 2010-06-18 13:50:19 UTC

Nice clean patch! Committed, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.