Bug 25042

Summary: [0.8, 0.9] initialize priv pointers correctly
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: gabbleAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=shortlog;h=refs/heads/08-privates
i915 platform: i915 features:

Description Simon McVittie 2009-11-11 11:13:29 UTC
The top four patches of <http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=shortlog;h=refs/heads/08-privates> improve on our use of priv pointers.

The oldest is a bug waiting to happen, which bit me while working on Bug #13157; I think at least this one should be merged in 0.8, since it makes our conventional style for priv pointers compile correctly, but then crash when used.

The second-oldest removes an uninitialized, unused priv pointer from GabbleConnectionManager. GabbleConnectionManagerPrivate is never defined, so this pointer, while useless, can't be dereferenced, and the patch is hence less important. Up to reviewers whether this is a candidate for 0.8.

The two newest are arguable; I think we should at least have them in 0.9, but probably not 0.8.
Comment 1 Will Thompson 2009-11-20 12:12:13 UTC
Eh, it's fine. Merged to 0.8. and master; will be in 0.8.9 and 0.9.3.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.