Bug 24847

Summary: [i965 bisected] OGLC/textRect.c takes 20+ minutes (was 13 minutes)
Product: Mesa Reporter: Shuang He <shuang.he>
Component: Drivers/DRI/i965Assignee: Eric Anholt <eric>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: high    
Version: git   
Hardware: Other   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Shuang He 2009-11-01 23:59:53 UTC 
System Environment:
--------------------------
Kernel  (drm-intel-next)a83a4400415893d2599a256f6842ac4d871dffd7
Libdrm  (master)b0b96636dbf93445dd532b09b21fa4fc5ce6bdc7
Mesa    (master)1cc16e1b831cef8e1573cc998cee3e55179bb830
Xserver         (master)d30637339963950910e5f5fb755b8465ac7dddb4
Xf86_video_intel        (master)10946118dd3a63f1375a1bfde0b2f0542a93c1c2


Bug detailed description:
-------------------------
This issue happens on G45
OGLC case textRect regressed due to following commit:

tree 72ec41c47245c8daf2ec50b40249ab462e32ff96
parent 2073006c9566b08888b4338748a843c645bd0db1
author Eric Anholt <eric@anholt.net> 1256934013 -0700
committer Eric Anholt <eric@anholt.net> 1256934034 -0700

i965: Fix BRW_WM_MAX_INSN to reflect current limits.

Part of fixing bug #24355.
Comment 1 Shuang He 2009-11-02 00:28:35 UTC 
add the missing culprit commit id:
2c30ee9bd69ed606b984c051748a7cdb34905eeb
Comment 2 Shuang He 2009-11-02 00:56:17 UTC 
OGLC case fpstate is also impacted greatly by this commit.it's now taking more than 20 minutes (was 3 minutes)
Comment 3 Eric Anholt 2009-11-10 16:58:48 UTC 
commit c5413839b3e99c7b162f1260142f3c175502b0ce
Author: Eric Anholt <eric@anholt.net>
Date:   Tue Nov 10 15:51:29 2009 -0800

    i965: avoid memsetting all the BRW_WM_MAX_INSN arrays for every compile.
    
    For an app that's blowing out the state cache, like sauerbraten, the
    memset of the giant arrays ended up taking 11% of the CPU even when only a
    "few" of the entries got used.  With this, the WM program compile drops back
    down to 1% of CPU time.
    
    Bug #24981 (bisected to BRW_WM_MAX_INSN increase).
Comment 4 Shuang He 2009-11-11 17:03:31 UTC 
verified on G45 against:
Xf86_video_intel 	(master)14109abf285866ad4cd99d0cd16b0954a0a73a62 
Mesa 	(master)e4a19ffb13746ae4f62adca412d086d9461ff432 
Kernel 	(drm-intel-next)5b8f0be0dce012d190a53d55240fe3fde6306476 
Libdrm  (master)89cc98c0d5c1b43a883f13210c472339dde1a4cf

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.