Bug 24741

Summary: FontUtil configuration: update, fix warnings, apply global maintenance
Product: xorg Reporter: Gaetan Nadon <memsize>
Component: Build/ModularAssignee: Gaetan Nadon <memsize>
Status: RESOLVED WONTFIX QA Contact: Xorg Project Team <xorg-team>
Severity: enhancement    
Priority: low CC: alan.coopersmith, peter.hutterer
Version: gitKeywords: janitor
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
i915 platform: i915 features:

Description Gaetan Nadon 2009-10-26 13:03:09 UTC
fontutil.m4 is included in tarball
EXTRA_DIST aclocal_DATA in font/util. Should not be there
(FYI: also done in xserver and libxtrans)

Inconsistent casing between fontrootdir and mapdir in confiure.ac
fontrootdir='${datadir}/fonts/X11'	[lowercase]
AC_SUBST(fontrootdir)			[lowercase]

mapdir='${fontrootdir}/util'		[lowercase]
MAPDIR="$mapdir"			[uppercase] extra definition
AC_SUBST(MAPDIR)			[uppercase]

In fontutil.pc:

The mapdir casing was changed from lowercase to uppercase presumably on purpose in: 
Perhaps someone thought it was necessary, but this adds one level of indirection and there is no evidence it is needed.

Executable bdftruncate in CLEANFILES
Not required, cleaned by default. Left over from the Perl days

In the case when --with-mapdir is used with an absolute path name, the fontrootdir location is ignored, so the mapdir is not relative to fontrootdir. I do not know if this causes a problem on a real running system. No action taken. Note that fontrootdir is not used by itself. 

Use dist_ prefix rather than EXTRA_DIST list
Use dist_mapfiles_DATA and remove $(mapfiles_DATA) from EXTRA_DIST. Providing accurate information up front to automake.

Hardcoded "SED = sed"
This may not be portable in the future. Autoconf provides AC_PROG_SED to locate an appropiate sed. Issues about sed I read were mostly from Solaris prior to 10.

Output of configure when checking for the presence of sed:
=>>>checking for a sed that does not truncate output... /bin/sed

This a candidate for for inclusion in XORG_MANPAGE_SECTIONS since they all use sed.

Directly using $(PACKAGE_STRING) instead.  Saves a line and one level of indirection.

Many target types in same makefile
Moved C code and man pages in /src and /man subdirs

Future: 'XORGMANNAME = X Version 11' is used in 161 makefiles so it is a candidate for inclusion in XORG_MANPAGE_SECTIONS macro.
Comment 1 Gaetan Nadon 2009-12-01 18:21:34 UTC
These issues will be addressed differently. Won't fix in this format.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.