| Summary: | xserver autogen.sh has --force option on autoreconf | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Gaetan Nadon <memsize> | ||||||
| Component: | Build/Modular | Assignee: | Gaetan Nadon <memsize> | ||||||
| Status: | RESOLVED NOTABUG | QA Contact: | Xorg Project Team <xorg-team> | ||||||
| Severity: | trivial | ||||||||
| Priority: | low | CC: | alan.coopersmith, daniel, peter.hutterer | ||||||
| Version: | git | Keywords: | janitor | ||||||
| Hardware: | x86-64 (AMD64) | ||||||||
| OS: | Linux (All) | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Attachments: |
|
||||||||
|
Description
Gaetan Nadon
2009-09-26 17:11:40 UTC
Created attachment 29873 [details] [review] [PATCH] autogen.sh: remove --force option from autoreconf Created attachment 29874 [details] [review] [PATCH] Makefile.am: do not distribute autogen.sh #24178 So I'm having some trouble understanding this.. > If the --force option is required as a workaround, I'll be happy to comment > both the problem and the workaround in autogen.sh. Otherwise a patch is > provided to remove the option. > what's the actual problem that removing --force fixes? > Unless there is a reason to distribute autogen.sh, a patch is provided to > remove it from the makefile. > similarly, what's wrong with having it in the tarball? (In reply to comment #3) > So I'm having some trouble understanding this.. > > > If the --force option is required as a workaround, I'll be happy to comment > > both the problem and the workaround in autogen.sh. Otherwise a patch is > > provided to remove the option. > > > what's the actual problem that removing --force fixes? None that I can find. Came to my attention while investigating excessive rebuilds. There is a claim that it was put there to fix a problem. If that is really the case, the same problem may be on other components as well. I'd like to come to a closure on this, either way. > > > Unless there is a reason to distribute autogen.sh, a patch is provided to > > remove it from the makefile. > > > similarly, what's wrong with having it in the tarball? We should distribute only what we intend to distribute. There could be legal issues when a file is unintentionally distributed and not properly licensed. There is also a need for consistency, either all tarballs have it or they don't. > Thanks for your comments Comment on attachment 29874 [details] [review] [PATCH] Makefile.am: do not distribute autogen.sh #24178 The distribution of autogen.sh issue is now the subject of a separate bug report #24183 Reading on Automake, the --force will regenerated macros and auxiliaries scripts like install.sh and others in case the version of Automake would have changed. This option is useful for developers who upgrade the build tools mid-air. It's not useful for distribution when everything is built from scratch. However there is a performance cost. On my box it's 35% slower to reconfigure with -f. But if you don't build from the top, you are not affected. Speed vs safety. It is useless and misleading to have this option only one component and not on the other 267. In the tool upgrade scenario, it would lead to an inconsistent build. I still think it should be removed. I'll wait some more for other opinions. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.