Bug 23814

Summary:

Several driver modules do not have a ChangeLog target in Makefile.am

Product:

xorg

Reporter:

Gaetan Nadon <memsize>

Component:

Build/Modular

Assignee:

Gaetan Nadon <memsize>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

enhancement

Priority:

low

CC:

alan.coopersmith, peter.hutterer

Version:

git

Keywords:

janitor

Hardware:

x86-64 (AMD64)

OS:

Linux (All)

Whiteboard:

i915 platform:

i915 features:

Bug Depends on:

24239, 24242

Bug Blocks:

Attachments:

Description	Flags
Patches and script to add ChangeLog command	none

Description Gaetan Nadon 2009-09-09 08:46:12 UTC

Summary of changes to be applied to the 33 driver modules
Adding XORG_CHANGELOG v1.2 macro in configure.ac
Adding CHANGELOG_CMD in Makefile.am
Adding ChangeLog in .gitignore
Deleting hand written ChangeLog file.

For xf86-video-vmware/vmwarectrl nested module, a CangeLog is not required as the sample module is not shipped and changes will be logged in the root ChangeLog

I'll provide a tar file with the patches.

Comment 1 Gaetan Nadon 2009-09-09 09:07:07 UTC

Created attachment 29353 [details]
Patches and script to add ChangeLog command

Comment 2 Alan Coopersmith 2009-09-09 11:29:38 UTC

If we're mass modifying this many modules, I'd like to wait until we get 
xorg-macros 1.3 out (should be today or tomorrow) and then change
the patches to instead do XORG_MACROS_VERSION(1.3) and then replace
XORG_MANPAGE_SECTIONS, XORG_RELEASE_VERSION & XORG_CHANGELOG with the
new XORG_DEFAULT_OPTIONS.

Thanks for tackling all these!

Comment 3 Gaetan Nadon 2009-09-09 13:07:23 UTC

(In reply to comment #2)
> If we're mass modifying this many modules, I'd like to wait until we get 
> xorg-macros 1.3 out (should be today or tomorrow) and then change
> the patches to instead do XORG_MACROS_VERSION(1.3) and then replace
> XORG_MANPAGE_SECTIONS, XORG_RELEASE_VERSION & XORG_CHANGELOG with the
> new XORG_DEFAULT_OPTIONS.
> 
> Thanks for tackling all these!
> 

I'd be happy to do both, perhaps in a different order. It will be just as easy to upgrade to version 1.3 macro for the whole driver directory in one go. The committer has only one issue to check for errors. I'd feel safer.

I noticed XORG_DEFAULT_OPTIONS was coming and would need to be deployed to the ~275 modules. Perhaps I can help with that. 

I haven't done ChangeLog for mesa and pixman, they have a complex configuration 
I don't feel comfortable changing.

Comment 4 Peter Hutterer 2009-09-09 15:53:50 UTC

On Wed, Sep 09, 2009 at 01:07:23PM -0700, bugzilla-daemon@freedesktop.org wrote:
> I noticed XORG_DEFAULT_OPTIONS was coming and would need to be deployed to the
> ~275 modules. Perhaps I can help with that. 

fwiw, instead of submitting patches it'd be better to submit a shell script
that modifies each file and prepares the commit message automatically. The
recent cvsignore patch files were a bit awkward to handle.

Comment 5 Alan Coopersmith 2009-09-09 16:10:24 UTC

Or just get direct committ access instead of going through intermediaries
like us...

Comment 6 Gaetan Nadon 2009-10-28 17:18:32 UTC

Comment on attachment 29353 [details]
Patches and script to add ChangeLog command

Patches are obsolete. New patches have been produced on local repo.

Comment 7 Gaetan Nadon 2009-10-28 17:25:56 UTC

Summary of changes
------------------

configure.ac will contain XORG_DEFAULT_OPTIONS
Makefile.am contains target to build ChangeLog
Hand-written ChangeLog file is deleted from git
.gitignore will contain default section which ignores generated ChangeLog

Patches have been created such that all 251 xorg/* modules have generated ChangeLog

Comment 8 Gaetan Nadon 2009-12-01 18:05:01 UTC

All modules have a ChangeLog target.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.