Bug 23028

Summary:

s3virge: compile error due to undefined macro GET_ABI_MAJOR

Product:

xorg

Reporter:

Gaetan Nadon <memsize>

Component:

Driver/s3virge

Assignee:

Gaetan Nadon <memsize>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

CC:

airlied

Version:

git

Keywords:

janitor

Hardware:

x86-64 (AMD64)

OS:

Linux (All)

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
[PATCH] s3virge: fix compile error due to undefined macro GET_ABI_MAJOR #23028	none

Description Gaetan Nadon 2009-07-29 14:43:07 UTC

s3v_driver.c:33:18: error: missing binary operator before token "("
make[2]: *** [s3v_driver.lo] Error 1

This was compiled on AMD64. The macro GET_ABI_MAJOR is not defined before being used. Starting with commit http://cgit.freedesktop.org/xorg/driver/xf86-video-s3virge/commit/?id=664d41155a5f60fa8ccf9c00d819d71d7fe0a238 the file xf86Resources.h is no longer included.

Other video drivers have made the same changes, but the macro definition is provided by one header file or another. I made a patch which includes xf86Module.h where the macro is defined.

Comment 1 Gaetan Nadon 2009-07-29 14:45:56 UTC

Created attachment 28174 [details] [review]
[PATCH] s3virge: fix compile error due to undefined macro GET_ABI_MAJOR #23028

Comment 2 Dave Airlie 2009-07-29 21:07:50 UTC

thanks I fixed it slightly different before I read this, I was rebuilding it, wonder why its not in the tinderbox.

Comment 3 Gaetan Nadon 2009-07-30 03:50:26 UTC

Thank you for your prompt response. I have verified the fix provided in http://cgit.freedesktop.org/xorg/driver/xf86-video-s3virge/commit/?id=7db324f9d862cb9e11db480a1e6143aa01a81e3e.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.