Bug 22966

Summary:	TpChannel Group code: check the Connection's self-handle too
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/kalfa/telepathy-glib.git;a=shortlog;h=refs/heads/remove_fixme_connection_self_handle
Whiteboard:
i915 platform:		i915 features:

Description Simon McVittie 2009-07-27 08:05:44 UTC

>      /* FIXME: should check against the Connection's self-handle too,
>       * after I add that API */

but that API has been added:

> TpHandle tp_connection_get_self_handle (TpConnection *self);

Comment 1 Cosimo Alfarano 2010-04-09 05:19:14 UTC

connection's self-handle is already checked with

>  if (handle == self->priv->group_self_handle ||
>         handle == tp_connection_get_self_handle (self->priv->connection))
> { ... }

the branch removes the misleading FIXME comment.

Comment 2 Simon McVittie 2010-04-12 10:08:07 UTC

review+, and since it's so trivial, I just merged it. The actual bug was fixed in 0.7.26, according to the git log.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.