| Summary: | Build.h: fails to build mesa & drm which are prereqs for xserver | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Gaetan Nadon <memsize> | ||||||
| Component: | Build/Modular | Assignee: | Gaetan Nadon <memsize> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||||
| Severity: | minor | ||||||||
| Priority: | low | CC: | peter.hutterer | ||||||
| Version: | git | Keywords: | janitor | ||||||
| Hardware: | x86-64 (AMD64) | ||||||||
| OS: | Linux (All) | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Attachments: |
|
||||||||
|
Description
Gaetan Nadon
2009-07-17 08:44:36 UTC
Created attachment 27795 [details] [review] [PATCH] Add mesa and drm modules with correct path #22823 Patch created on top of patch for #22616 the git repositories for both components are under mesa/mesa and mesa/drm. So what the build.sh script does seems to make sense. Why do you have a different directory structure? (In reply to comment #2) > the git repositories for both components are under mesa/mesa and mesa/drm. So > what the build.sh script does seems to make sense. > > Why do you have a different directory structure? > Thanks for looking into this. The directory structure I have comes from git_xorg.sh as explained on ModularDevelopersGuide. The example extracts code in /tmp/src which I refer to as $prefix. --------------------------------------------------------------------- When done, you should see the following: $ ls -F app/ data/ doc/ driver/ drm/ font/ git_xorg* lib/ pixman/ proto/ util/ xcb/ xserver/ ---------------------------------------------------------------------- Note that "drm" is under $prefix and not under $prefix/mesa as the git repository path mesa/drm might suggest. Just like "xserver" is under $prefix/xserver and not $prefix/xorg/xserver as the git repository path xorg/xserver might suggest. This makes drm a module as opposed to a component of the mesa module. I assumed the same pattern for mesa (a module), which is missing. Either way is supported by the build system (I have tested both). I don't know what is the most accurate representation of the mesa & drm archicture. This is how build.sh currently sees the structure: $prefix/mesa/drm drm is a component of the mesa module $prefix/mesa/mesa mesa is a component of the mesa module I can change the git_xorg.sh to match build.sh. In any case, the line to build mesa in build.sh must be uncommented. BTW, I do not have permission to upload (overwrite) an attachment in the wiki page. I have done some looking around for instructions on building drm and mesa both at X.Org (http://www.x.org/wiki/Development/git) and outside. They all follow the same pattern: git clone git://git.freedesktop.org/git/mesa/drm cd drm git clone git://git.freedesktop.org/git/mesa/mesa cd mesa They do not ask to create a toplevel directory "mesa" in front of the git created directory "drm" or "mesa" (these instructions do not use build.sh). This is also consistent with the ModularDevelopersGuide. With the proposed patch, build.sh would work on already extracted mesa & drm code. Created attachment 28009 [details] [review] [PATCH] build.sh: uncomment #build mesa (prereq for xserver) This patch keeps everything as they were, but simply uncomments the "build mesa mesa" line. The new --clone ensures a consistent and predictable directory structure. Having a single top level directory for mesa provides flexibility for the future. I have replaced the original patch with the one that just uncomments the line to build mesa. Pushed as 48e735ca843c4de83c29c78532d5e1bca45f47d5. Thanks for the patch. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.