Bug 22675

Summary:	Makefile.am breaks build: undefined variables used
Product:	xorg	Reporter:	Gaetan Nadon <memsize>
Component:	Build/Modular	Assignee:	Xorg Project Team <xorg-team>
Status:	RESOLVED INVALID	QA Contact:	Xorg Project Team <xorg-team>
Severity:	minor
Priority:	low	Keywords:	janitor
Version:	git
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Gaetan Nadon 2009-07-08 10:55:08 UTC

While doing a full build from a nwly cloned git repo:

EXTRA_DIST: variable `FONTCACHE_SRCS' is used but `FONTCACHE_SRCS' is undefined
EXTRA_DIST: variable `GE_SRCS' is used but `GE_SRCS' is undefined
EXTRA_DIST: variable `DISTKBDSOURCES' is used but `DISTKBDSOURCES' is undefined
SUBDIRS: variable `DRI_SUBDIRS' is used but `DRI_SUBDIRS' is undefined
EXTRA_DIST: variable `I386_SRCS' is used but `I386_SRCS' is undefined
EXTRA_DIST: variable `PORTIO_SRCS' is used but `PORTIO_SRCS' is undefined
EXTRA_DIST: variable `INTERNALMALLOC_SRCS' is used but `INTERNALMALLOC_SRCS' is undefined

The Makefile.am involved:
xserver/Xext/Makefile.am FONTCACHE_SRCS GE_SRCS
xserver/hw/xfree86/os-support/misc/Makefile.am: I386_SRCS PORTIO_SRCS
xserver/hw/xfree86/common/Makefile.am DISTKBDSOURCES
xserver/hw/xfree86/os-support/Makefile.am DRI_SUBDIRS
xserver/os/Makefile.am INTERNALMALLOC_SRCS

In the first case I investigated, FONTCACHE_SRCS is included in EXTRA_DIST but it is not defined. Looking at earlier branches, it was defined for fontcache.c which was removed from the tree. It looks as if the EXTRA_DIST variable had not been updated at the time of the removal. 

I intend to fix this by updating the EXTRA_DIST variable in this case and in similar cases. This prevents xservr from building which prevents other modules from building and impact other bug fixes testing.

Comment 1 Gaetan Nadon 2009-07-17 19:14:53 UTC

The clean-up should still be done, but it does not break the build when using automake 1.10. By default, on Ubuntu Jaunty, automake1.7 is installed. The package is not named "automake" but "automake1.7". These unused variables are treated as errors under 1.7. Installing package "automake" gives me v 1.10.

Here is the result of my investigation anyway:
xserver/Xext/Makefile.am FONTCACHE_SRCS GE_SRCS
Makefile variable FONTCACHE_SRCS and GE_SRCS are undefined. Source code was removed, but EXTRA_DIST was not updated"

xserver/hw/xfree86/os-support/misc/Makefile.am: I386_SRCS PORTIO_SRCS
Makefile variable I386_SRCS and PORTIO_SRCS are undefined. There is no need for an EXTRA_DIST variable, removed."

xserver/hw/xfree86/common/Makefile.am DISTKBDSOURCES
Makefile variable DISTKBDSOURCES is undefined. Source code was removed, but EXTRA_DIST was not updated. Was used in v1.3.0, now removed."

# this is a hack for now.  as above we don't have rules to build all of these
# yet, but we want to make sure they all get into the distball.  this should
# eventually go away.
DISTKBDSOURCES = xf86Kbd.c xf86KbdBSD.c xf86KbdLnx.c xf86KbdMach.c

xserver/hw/xfree86/os-support/Makefile.am DRI_SUBDIRS
Makefile variable DRI_SUBDIR is undefined. May be a typo. The parent makefile defines DRI_SUBDIR (singular) which is set to 'dri' if the DRI env variable is set. Removed DRI_SUBDIRS. There are no dri subdirectory.

xserver/os/Makefile.am INTERNALMALLOC_SRCS
Makefile variable INTERNALMALLOC_SRCS is undefined. Removed from EXTRA_DIST definition."
In branch 1.4:
# FIXME: Add support for these in configure.ac
INTERNALMALLOC_SRCS = xalloc.c

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.