| Summary: | Patch to update comments for Crimean Tatar (Crimean Turkish) keyboard layouts to give Özgür Qarahan the credit due | ||
|---|---|---|---|
| Product: | xkeyboard-config | Reporter: | Reşat SABIQ (Reshat) <tilde.birlik> |
| Component: | General | Assignee: | xkb |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | benjsc, daniel, peter.hutterer |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Patch to update comments: version 2. | ||
|
Description
Reşat SABIQ (Reshat)
2009-06-03 23:13:00 UTC
Grand, committed. Thanks! Please check in git. (In reply to comment #1) > Grand, committed. Thanks! Please check in git. > Based on the diff between the submitted patch and the commit I'd like to mention several things that don't look right to me: 1. Sergey deleted the date information from the patch: 1.1. w/o mentioning it 1.2. w/o discussing it 1.3. despite the fact that comments throughout files are essentially free-form: there is no ground for abridging this information. 2. Most keyboard layout variants in general contain date information in comments. 3. The date information provided in the patch was factual, relevant, and harmless. 4. Now Crimean Tatar (Crimean Turkish) layouts are the only ones without a date in comments in the file involved, the rest of the keyboard layouts in the file contain date information in comments, thus an inconsistency has now been introduced. 4.1. An person unaware of this discussion looking at the file now, could think: "Why have these 2 decided not to include date information in comments, whereas all other keyboard layouts in the file have it?". And of course such a person wouldn't be aware that it was due to maintainer's "special mistreatment" and not due to the contributors' discretion. While this may not seem significant, i personally would not like to be a subject of such wondering by anybody, especially since the inconsistency is caused by the maintainer. Therefore, i believe date info should be included in comments. Please add one of the following lines as the 2nd line of comments (as it was in the patch provided): // First released: 2009-02-24 (1.5-2ubuntu5). // First released (by Ubuntu): 2009-02-24. // First released: 2009. // Year added: 2009. In my opinion, there is no reason whatsoever not to use the 1st (the best format IMHO) or 2nd comment line suggested above: this is factual, relevant, and harmless information. If you look around at the comments in symbols/ files, you can see all kinds of information in comments, sometimes even with spelling errors. And there is no reason to abridge (or censor) such information in comments, especially something as consistent throughout the comments in files as dates. P.S. This back-and-forth has taken way too much time, and i can't spend any more time on a maintainer's special mistreatment. Maybe indeed he should ask somebody else, like Daniel, to make updates for crh keyboard layouts. If for whatever reason the date info isn't added in the next few weeks, it'll probably end up being provided as a separate patch in the future. Done. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.