Bug 21848

Summary:	Refactor handling of incoming call state notifications.
Product:	Telepathy	Reporter:	Will Thompson <will>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=shortlog;h=refs/heads/refactor-hold
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	21836
Bug Blocks:

Description Will Thompson 2009-05-21 03:52:08 UTC

Now that XEP-0167's call state notifications have been defined all to be orthogonal, the per-content approach I used makes much less sense: hold and ringing are per-session, not per-content.

My refactor-hold branch moves the ringing and hold states onto the session, leaving a "mute" flag on RTP contents which is set for completeness (it's never used, since we don't have Tp API for mute yet).

Comment 1 Guillaume Desmottes 2009-05-26 04:06:35 UTC

http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=commitdiff;h=ccb4140e2776510da324baeab59faadded0dd4a5
seems a bit unfortunate from a code design pov. But I don't know the current jingle's code design so maybe it's not that bad.

Except that the branch looks good

Comment 2 Will Thompson 2009-05-26 04:33:31 UTC

Merged, will be in 0.7.28.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.