| Summary: | X server logs font path all one one very long unreadable line. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Mike A. Harris <mharris> | ||||
| Component: | Server/General | Assignee: | Xorg Project Team <xorg-team> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | high | CC: | ajax, gajownik, npukol, roland.mainz | ||||
| Version: | unspecified | Keywords: | janitor | ||||
| Hardware: | x86 (IA32) | ||||||
| OS: | Linux (All) | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 3116 | ||||||
| Attachments: |
|
||||||
nobody objects ;) Created attachment 4492 [details] [review] this patch change the log output as described in the bug (In reply to comment #2) > Created an attachment (id=4492) [edit] Sorry for the stupid question (I'm just learning programming in C): shouldn't you use strchr() function instead if index()? http://www.opengroup.org/onlinepubs/009695399/functions/index.html (In reply to comment #3) > Sorry for the stupid question (I'm just learning programming in C): shouldn't > you use strchr() function instead if index()? > http://www.opengroup.org/onlinepubs/009695399/functions/index.html I used the function "index", because this is used also in other functions in the file "xf86Config.c". Functionality is the same. Which of both is more portable, I don't know. applied to head and 1.1 branch, thanks! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
The X server logs the complete fontpath to the log, however it is all on one very long line, which is rather unreadable. (**) FontPath set to "/usr/X11R6/lib/X11/fonts/75dpi:unscaled,/usr/X11R6/lib/X11/fonts/misc:unscaled,/usr/X11R6/lib/X11/fonts/misc,/usr/X11R6/lib/X11/fonts/Speedo,/usr/X11R6/lib/X11/fonts/TTF,/usr/X11R6/lib/X11/fonts/Type1,/usr/X11R6/lib/X11/fonts/hanyang,/usr/share/fonts/default/Type1,/usr/share/fonts/ko/saemmul,/usr/share/fonts/hanyang" A nice minor enhancement to break this up on FPE boundaries would make the font path more readable, and also help to spot font path related issues in bug reports. Something like: (**) FontPath set to: /usr/X11R6/lib/X11/fonts/75dpi:unscaled, /usr/X11R6/lib/X11/fonts/misc:unscaled, /usr/X11R6/lib/X11/fonts/misc, /usr/X11R6/lib/X11/fonts/Speedo, /usr/X11R6/lib/X11/fonts/TTF, /usr/X11R6/lib/X11/fonts/Type1, /usr/X11R6/lib/X11/fonts/hanyang, /usr/share/fonts/default/Type1, /usr/share/fonts/ko/saemmul, /usr/share/fonts/hanyang If nobody objects, I'll create a patch to do this, and commit to CVS.