Bug 20364

Summary:	[PATCH] Add support of Occitan layout
Product:	xkeyboard-config	Reporter:	tmetz
Component:	General	Assignee:	xkb
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	tmetz
Version:	unspecified	Keywords:	NEEDINFO, patch
Hardware:	All
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Path for adding support of Occitan layout Add support of Occitan layout (languageList tag added)

Description tmetz 2009-02-27 12:31:42 UTC

Created attachment 23379 [details] [review]
Path for adding support of Occitan layout

Add support of Occitan layout
Occitan is a language spoken in the south of France
Add á, í, ò, ó et ú, Á, Í, Ò, Ó, Ú, ñ, Ñ letters from french layout

Comment 1 Sergey V. Udaltsov 2009-02-27 12:34:39 UTC

I like your patch, it is clean and well-structured. Just out of curiosity - wouldn't it make sense to base it on some french layout (using "include") - or the difference is too bit?

Another thing - would you consider adding <languageList> to your variant?

Comment 2 tmetz 2009-03-01 05:58:19 UTC

Thanks for your suggestions.

(In reply to comment #1)
> I like your patch, it is clean and well-structured. Just out of curiosity -
> wouldn't it make sense to base it on some french layout (using "include") - or
> the difference is too bit?

Maybe, we have : 
- first row is unchanged,
- second row all keys are changed (AltGr)
- third row 7 keys are changed (AltGr)
- fourth row 2 keys are changed (AltGr)

I don't know if it is possible to redefine only keys from [AltGr] and [AltGr shift] columns (the two first columns are exactly the same as french layout).

If you think it would be more compliant to xkeybvoard-config coding rules to use "include" directive, I think it is better to apply it.

> Another thing - would you consider adding <languageList> to your variant?
> 

I can prepare a new patch with <languageList><iso639Id>oci</iso639Id></languageList> line.

Just to be sure, the iso639 code for Occitan is oci in iso639-3 and oc in iso638-2. Is it better to use iso639-3 or iso639-2 code (the LANG variable is set to oc) ?

Comment 3 Sergey V. Udaltsov 2009-03-01 06:42:17 UTC

Well, I see groups 2-4 are seriously changed, probably there is no advantage in using "include". So, let's leave things as they are.

So far, I am trying to use 639-3.

Comment 4 tmetz 2009-03-03 13:17:22 UTC

Created attachment 23483 [details] [review]
Add support of Occitan layout (languageList tag added)

The patch with langageList tag (also, oc has been replaced by oci).
This patch replaces the previous one.

Comment 5 Sergey V. Udaltsov 2009-03-03 14:46:26 UTC

Good! Committed!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.