Bug 19927

Summary:	dbus_g_method_return_error should accept const GError
Product:	dbus	Reporter:	Alberto Mardegan <mardy>
Component:	GLib	Assignee:	Rob Taylor <rob.taylor>
Status:	VERIFIED FIXED	QA Contact:	John (J5) Palmieri <johnp>
Severity:	normal
Priority:	medium	CC:	walters
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	0001-Bug-19927-Use-const-for-GError-param-we-re-not-m.patch

Description Alberto Mardegan 2009-02-03 03:12:15 UTC

dbus_g_method_return_error is not modifying or freeing the GError it receives, so its error parameter should have the "const" modifier added.

Comment 1 Colin Walters 2009-02-25 08:29:45 UTC

Created attachment 23286 [details] [review]
0001-Bug-19927-Use-const-for-GError-param-we-re-not-m.patch

Comment 2 Simon McVittie 2009-04-15 13:11:05 UTC

Colin: not that I'm really a reviewer for dbus-glib, but I approve of this patch. (Any chance you could look at some of mine? :-)

Comment 3 Colin Walters 2009-04-16 10:03:05 UTC

Thanks for the review, pushed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.