Bug 19424

Summary:

[patch] migrate to dixLookupResource

Product:

xorg

Reporter:

Shunichi Fuji <palglowr>

Component:

Server/General

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Keywords:

patch

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
main patch	none
mark some deprecated functions as _X_DEPRECATED	none
one regression found	none
uniform pointer type to return type.	none

Description Shunichi Fuji 2009-01-06 08:19:23 UTC

Created attachment 21723 [details] [review]
main patch

this patch convert to use dixLookupResource directly for some function in dix/deprecated.c.

 Xext/mbuf.c                          |   22 ++-
 Xext/panoramiX.c                     |    7 +-
 Xext/panoramiX.h                     |    2 -
 Xext/panoramiXprocs.c                |  330 +++++++++++++++++-----------------
 Xext/saver.c                         |   26 ++--
 Xext/security.c                      |    4 +-
 Xext/shape.c                         |   39 ++--
 Xext/shm.c                           |   14 +-
 Xext/sync.c                          |   65 +++-----
 Xext/xf86bigfont.c                   |    8 +-
 Xext/xvdisp.c                        |  114 +++++++-----
 Xext/xvdix.h                         |   12 --
 Xext/xvmain.c                        |    4 +-
 Xext/xvmc.c                          |   30 +++-
 Xi/chdevcur.c                        |    6 +-
 Xi/extgrbdev.c                       |   12 +-
 composite/compext.c                  |   15 +-
 composite/compinit.c                 |    3 +-
 damageext/damageextint.h             |    2 +-
 dbe/dbe.c                            |   34 ++---
 dix/colormap.c                       |   18 +-
 dix/cursor.c                         |    3 +-
 dix/dispatch.c                       |    5 +-
 dix/dixfonts.c                       |   29 ++--
 dix/dixutils.c                       |    3 +-
 dix/events.c                         |    7 +-
 dix/resource.c                       |   11 +-
 dix/window.c                         |   20 ++-
 fb/fbcmap.c                          |    4 +-
 glx/glxcmds.c                        |   24 ++--
 glx/glxscreens.c                     |    3 +-
 glx/xfont.c                          |    4 +-
 hw/dmx/dmx.c                         |    9 +-
 hw/dmx/dmxextension.c                |   14 +-
 hw/dmx/dmxgcops.c                    |    8 +-
 hw/dmx/dmxpict.c                     |   38 ++--
 hw/dmx/dmxwindow.c                   |   10 +-
 hw/dmx/glxProxy/glxcmds.c            |  158 ++++++++++-------
 hw/dmx/glxProxy/glxext.c             |    6 +-
 hw/kdrive/src/kcmap.c                |    5 +-
 hw/vfb/InitOutput.c                  |    4 +-
 hw/xfree86/common/xf86cmap.c         |    4 +-
 hw/xfree86/dixmods/extmod/xf86dga2.c |    4 +-
 hw/xfree86/dri/dri.c                 |    2 +-
 hw/xfree86/vgahw/vgaCmap.c           |    4 +-
 hw/xnest/Color.c                     |   18 +-
 hw/xnest/Window.c                    |    9 +-
 hw/xquartz/applewm.c                 |    9 +-
 hw/xwin/wincmap.c                    |    4 +-
 hw/xwin/winmultiwindowicons.c        |    8 +-
 hw/xwin/winmultiwindowwindow.c       |    2 +-
 hw/xwin/winwin32rootlesswindow.c     |    2 +-
 hw/xwin/winwindowswm.c               |    9 +-
 mi/micmap.c                          |   10 +-
 mi/miexpose.c                        |    2 +-
 randr/randr.c                        |    6 +-
 randr/randrstr.h                     |   10 -
 randr/rrcrtc.c                       |  103 +++++------
 randr/rrdispatch.c                   |    5 +-
 randr/rrmode.c                       |   25 +--
 randr/rroutput.c                     |   12 +-
 randr/rrproperty.c                   |   24 ++-
 record/record.c                      |    6 +-
 render/picture.c                     |    4 +-
 render/picturestr.h                  |    2 +-
 render/render.c                      |  187 ++++++-------------
 xfixes/cursor.c                      |    8 +-
 xfixes/select.c                      |    5 +-
 xfixes/xfixes.h                      |    2 +-
 69 files changed, 792 insertions(+), 826 deletions(-)

Comment 1 Shunichi Fuji 2009-01-06 08:22:15 UTC

Created attachment 21724 [details] [review]
mark some deprecated functions as _X_DEPRECATED

if these functions could remove now, minor cleanup is needed ...

Comment 2 Shunichi Fuji 2009-01-06 09:04:09 UTC

Created attachment 21725 [details] [review]
one regression found

Comment 3 Shunichi Fuji 2009-01-07 21:28:28 UTC

Created attachment 21785 [details] [review]
uniform pointer type to return type.

low importance.

Comment 4 Corbin Simpson 2010-03-27 06:09:54 UTC

Tagging patch; will triage later.

Comment 5 Matt Turner 2010-12-03 16:50:14 UTC

Patches don't apply.

Please rebase them and send to xorg-devel@lists.x.org. Attaching patches in bugzilla is a great way for them to get lost and be ignored. :\

Comment 6 Julien Cristau 2010-12-11 01:10:12 UTC

Should be fixed in master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.