Bug 19239

Created attachment 21408 [details]
xorg.conf

what's your laptop model? Is this a regression, i.e works before but fails with latest driver? Need more information. pls refer to http://intellinuxgraphics.org/how_to_report_bug.html

Created attachment 21454 [details]
dmesg

Created attachment 21455 [details]
lspci

ok, 

Here's a bit more:

Linux 2.6.28-rc9 #2 Sat Dec 20 03:46:53 EST 2008 i686 unknown unknown GNU/Linux

The i915 chipset fails to start up,  with no screens found on 2.6.99.1 current intel driver.

The 2.5.99.1 driver starts without issue.

This is on a centrino based laptop (Mirrus), running Slackware 10.2.

zhenyu, it seems your LVDS detection patch has an exception now...

Well, acpi button has told driver the lid is closed, but lid is really open. So this is a bug for acpi people ;)

Cheryl, please check /proc/acpi/button/lid/state, is it saying close when your laptop's lid is open? Have you tested with other kernel versions?

hi, Cheryl
    From the info in comment #7 it seems that the LID state is incorrect.
    Will you please attach the output of acpidump?
    The latest acpidump tool(20071114) can be found in 
    http://www.kernel.org/pub/linux/kernel/people/lenb/acpi/utils/
    
    Thanks.

Created attachment 21459 [details]
acpidump_122408


Ok. 

confirmed:

Linux 2.6.28-rc9

/proc/acpi/button/lid/LID/state
state:      closed

Linux 2.6.27

/proc/acpi/button/lid/LID/state
state:      closed

Yep, this is with the lid open.

It looks like the current code is actually paying attention to this whereas the previous code didn't.

Hi, Cheryl
    From the acpidump it seems that the LID state is not initailized by BIOS.
    >Method (_LID, 0, NotSerialized)
    {
         Return (LIDS) // LIDS is defined in BIOS NVS memory region
    }
    Only after LID is closed and reopened, the LIDS can be updated correctly.
    
    Will you please confirm whether the LID state is incorrect after the LID is closed and reopened?
    Thanks.

That did it, and X started right up. 

/proc/acpi/button/lid/LID/state
state:      open

Hi, Cheryl
    Thanks for the test.
    From the test it seems that the LID state is correct after the LID is closed and reopened it.
    Now the issue is related with BIOS. It had better be fixed by BIOS upgrading. If an EC internal register in AML code is defined explicitly that reflected the correct LID state, this issue can be workaround by using the custom DSDT. But unfortunately we can do nothing as there is no such an EC internal register.
    
    Thanks.

Nice analysis! Yakui, thanks a lot! Cheryl, could you attach lspci -nv? I can make a quirk for this kind of broken bios in video driver.

Created attachment 21473 [details]
lspci_nv


Ok, cool. Looks like that should do it for this one.

Here it is.

Created attachment 21474 [details] [review]
quirk broken acpi lid

Please test with this patch, if this still doesn't work without lid open/close hack, please paste src/bios_render/swf_dumper output.

Yep, looks like that did it, no open/close needed. 

Pushed. Close.

commit fcd280b730f86ea54ecd89d3e037e71f8375b5f5
Author: Zhenyu Wang <zhenyu.z.wang@intel.com>
Date:   Mon Dec 29 10:05:17 2008 +0800

    Bug #19239: Add a quirk for broken ACPI lid state
    
    For broken hardware/bios with incorrect ACPI LID state,
    there's machine that can not be fixed in ACPI way, customed
    DSDT that reprogram _LID method to read EC state. Although
    this is ACPI issue, this quirk can be used to work around that.