Bug 19139

Summary:	[965 OGLC] Scissor testing does not work correctly
Product:	Mesa	Reporter:	Ian Romanick <idr>
Component:	Drivers/DRI/i965	Assignee:	Eric Anholt <eric>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	eric
Version:	git	Keywords:	regression
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Ian Romanick 2008-12-17 11:45:44 UTC

All subtests in the scissor.c conformance test are failing.  Since this test used to pass, I spent some quality with with git-bisect.  I tracked the failure down to the following commit.

commit cb433d91c6e198b7c77f747f1a38803532bc9be9
Author: Eric Anholt <eric@anholt.net>
Date:   Sat Dec 6 14:21:12 2008 -0800

    intel: Fix glBitmap blit acceleration for FBO destinations.
    
    Bug #18914.  Fixes fbo_firecube hang due to drawing outside the FBO bounds.
    Thanks to Pierre Willenbrock for debugging the issue.

Comment 1 Ian Romanick 2008-12-17 12:03:01 UTC

This same commit is also responsible for the failures in windowpos.c and bitmap-pos.c.

I looked at the code a bit.  The only thing that looked like it could leak into non-bitmap rendering is the call to intel_get_cliprects.  That function can set some context state in some cases.  The comment says "FBO or DRI2 rendering, which can just use the fb's size," but I wonder if this accidentally leaking into other cases?

Comment 2 Eric Anholt 2008-12-17 22:19:40 UTC

Initial patch series that doesn't fix it quite yet posted to mesa3d-dev.

Comment 3 Eric Anholt 2008-12-19 13:06:25 UTC

commit 1db63713046efd49071aae448105df8a80e1e83d
Author: Eric Anholt <eric@anholt.net>
Date:   Thu Dec 18 16:00:09 2008 -0800

    intel: Fix glBitmap top/bottom clipping.
    
    Bug #19139.

(Actually needs the previous patches in the series as well)

Comment 4 Adam Jackson 2009-08-24 12:31:22 UTC

Mass version move, cvs -> git

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.