Bug 18649

Summary: xf86-input-mouse fails to build for linux
Product: xorg Reporter: Peter Breitenlohner <peb>
Component: Input/MouseAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: critical    
Priority: medium Keywords: patch
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
fix linux build none

Description Peter Breitenlohner 2008-11-21 01:58:27 UTC 
Created attachment 20489 [details] [review]
fix linux build

Building the xf86-input-mouse driver for linux fails.

The build succeeds with the attached patch and I strongly suspect analogous patched will be needed for other OSes.
Comment 1 Peter Hutterer 2008-11-25 20:39:16 UTC 
Please make sure you have all the necessary paths setup, the build works fine
on my box here. Before reporting build errors, please check
http://tinderbox.freedesktop.org/ (for linux builds, anyway).
Comment 2 Peter Breitenlohner 2008-11-26 01:06:08 UTC 
(1) So it works for you, presumably because you have (the headers from) the latest git versions of inputproto, libxi, and/or xorg-server installed.
Shouldn't then configure.ac require sufficiently recent versions of the .pc files?

The compilation certainly fails with installed headers from Xorg-7.4

(2) The part in lnx_mouse.c with HAVE_XORG_CONFIG_H (never defined) is obsolete and confusing, and ought to be removed.

(3) When replacing (or supplementing) this by "#include <xorg-server.h>", as in bsd_mouse.c or sun_mouse.c, compilation succeeds with headers from Xorg-7.4
Comment 3 Peter Hutterer 2008-12-02 22:35:45 UTC 
Pushed as cd476cc0932bf9440a05e460cd22dbe584585746. Thanks for the patch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.