Bug 18479

Summary: VPATH build for viewres, xfd, xgc, xmh, and xsm fails
Product: xorg Reporter: Peter Breitenlohner <peb>
Component: App/xsmAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium Keywords: janitor, patch
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
patch for viewres
none
patch for xfd
none
patch for xgc
none
patch for xmh
none
patch for xsm none

Description Peter Breitenlohner 2008-11-11 01:18:30 UTC 
Created attachment 20208 [details] [review]
patch for viewres

These five apps copy, e.g., app-defaults/Viewres.ad to app-defaults/Viewres but don't ensure that the directory ./app-defaults exists. Thus a VPATH build (objdir != srcdir) will fail.

Historically, in the monolithic build Viewres.ad was installed as Viewres by a suitable imake rule. The reason for this certainly was the fact that an executable viewres and an app default file Viewres cannot coexist on a case insensitive filesystem.

For the modular build automake requires (sort of) to create a file Viewres that will then be installed. In order to cope with case insensitive filesystems that is now done in a subdirectory app-defaults. This, however, allows to distribute the app default files under their final names, no need to copy them, no need to ensure the existence of ./app-defaults.

Moreover, defining them as dist_appdefault_DATA avoids the necessity to mention them under EXTRA_DIST. All this simplifies Makefile.am considerably.

Attached are five small patches along these lines for the five apps mentioned above.
Comment 1 Peter Breitenlohner 2008-11-11 01:20:01 UTC 
Created attachment 20209 [details] [review]
patch for xfd
Comment 2 Peter Breitenlohner 2008-11-11 01:20:33 UTC 
Created attachment 20210 [details] [review]
patch for xgc
Comment 3 Peter Breitenlohner 2008-11-11 01:21:01 UTC 
Created attachment 20211 [details] [review]
patch for xmh
Comment 4 Peter Breitenlohner 2008-11-11 01:21:33 UTC 
Created attachment 20212 [details] [review]
patch for xsm
Comment 5 Paulo César Pereira de Andrade 2008-11-27 21:41:26 UTC 
  Thanks for the patches.

  All of them were applied.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.