Bug 18027

Summary: HP_RECOVERY partition not ignored
Product: hal Reporter: Bradley Baetz <bbaetz>
Component: miscAssignee: David Zeuthen (not reading bugmail) <zeuthen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: danny.kukawka
Version: unspecifiedKeywords: patch
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch

Description Bradley Baetz 2008-10-12 04:11:00 UTC
Created attachment 19597 [details] [review]
Patch

Using (on Fedora 9):

hal-0.5.11-2.fc9.x86_64
hal-info-20080607-1.fc9.noarch

My HP 6500 laptop's recovery partition is no longer ignored by hal, and its mounted when I log in. Looking at the exceptions in 20-storage-methods.fdi there is a rule:

      <!-- HP ships desktops with a recovery partition -->
      <match key="volume.fstype" string="vfat">
        <match key="volume.label" string="HP_RECOVERY">
          <merge key="volume.ignore" type="bool">true</merge>
        </match>
      </match>

However, this doesn't match for me because the recovery partition is NTFS. I'm not sure why anything is checking the fstype, but I've attached a patch to look for either.

The hard drive got replaced by HP (under warranty) and it broke then. I don't have the old drive to compare against.
Comment 1 Danny Kukawka 2008-10-13 03:14:38 UTC
commit fba24a693867984e832fd2eb8a182b715e66a289
Author: Danny Kukawka <danny.kukawka@web.de>
Date:   Mon Oct 13 12:12:34 2008 +0200

    unify set volume.ignore for recovery partitions

    Unifyed handling/matching of recovery partitions to set volume.ignore
    to true. This should also fix fd.o#18027.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.