Bug 17802

Summary:	[swrast] Glean test pointSprite fails
Product:	Mesa	Reporter:	Ian Romanick <idr>
Component:	Mesa core	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	17784

Description Ian Romanick 2008-09-26 14:33:52 UTC

Not only is the glean pointSprite test failing on 965, but it is also broken in the software rasterizer (swrast_dri.so).  The output of the test is below.  It looks like only the test that set the coordinate origin to GL_LOWER_LEFT are failing.  Could this be related to recent TNL-to-shader changes?

Incorrect pixel at (19, 19):
	it should be rendered with color: (0, 1, 0), actual read: (0, 0, 1)
	Primitive type: GL_POINTS
	Coord Origin at: GL_LOWER_LEFT
	PointSize: 1.85
Incorrect pixel at (19, 19):
	it should be rendered with color: (0, 1, 0), actual read: (0, 0, 1)
	Primitive type: GL_POLYGON
	Coord Origin at: GL_LOWER_LEFT
	PointSize: 1.85
pointSprite:  FAIL rgba8, db, z24, s8, win+pmap, id 33
	5 tests passed, 2 tests failed.
Incorrect pixel at (19, 19):
	it should be rendered with color: (0, 1, 0), actual read: (0, 0, 1)
	Primitive type: GL_POINTS
	Coord Origin at: GL_LOWER_LEFT
	PointSize: 1.85
Incorrect pixel at (19, 19):
	it should be rendered with color: (0, 1, 0), actual read: (0, 0, 1)
	Primitive type: GL_POLYGON
	Coord Origin at: GL_LOWER_LEFT
	PointSize: 1.85
pointSprite:  FAIL rgba8, db, z24, s8, win+pmap, id 34
	5 tests passed, 2 tests failed.
Incorrect pixel at (19, 19):
	it should be rendered with color: (0, 1, 0), actual read: (0, 0, 1)
	Primitive type: GL_POINTS
	Coord Origin at: GL_LOWER_LEFT
	PointSize: 1.85
Incorrect pixel at (19, 19):
	it should be rendered with color: (0, 1, 0), actual read: (0, 0, 1)
	Primitive type: GL_POLYGON
	Coord Origin at: GL_LOWER_LEFT
	PointSize: 1.85
pointSprite:  FAIL rgba8, win+pmap, id 99
	5 tests passed, 2 tests failed.

Comment 1 Brian Paul 2008-10-06 10:36:02 UTC

I'm not sure what might have changed to cause the failure, but digging into the swrast case, it looks like the texcoords need to be more carefully computed for the spans.  I'm checking in a fix for that.

In the progs/demos/spriteblast demo, press 'o' to toggle the sprite coord origin.  The "GL" should flip.  Does that work on i965?

Comment 2 Ian Romanick 2008-10-17 11:47:06 UTC

This seems to be working for both swrast and i965 now.  All my pointsprite tests pass.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.