| Summary: | inconsistent comment/error message and src code in _mesa_BindTexture() | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Jacek <jacek____> |
| Component: | Mesa core | Assignee: | mesa-dev |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | trivial | ||
| Priority: | low | Keywords: | janitor |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
The comment probably goes back to when we only had 1D, 2D and 3D targets. Fixed in git. There is still the "wrong dimensionality" message in the _mesa_error() log :): _mesa_error( ctx, GL_INVALID_OPERATION, "glBindTexture(wrong dimensionality)" ); Error msg fixed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
OpenGL spec, ver. 2.1 Section J.5 specifies/clarifies a requirement concerning texture target type (and not the dimensionality) of the to-be-bound texture: "the texture object passed to BindTexture must match the specified target, not just the dimensionality of target". The comment/error message in the Mesa code refers to the texture dimensionality: ... /* error checking */ if (newTexObj->Target != 0 && newTexObj->Target != target) { /* the named texture object's dimensions don't match the target */ _mesa_error( ctx, GL_INVALID_OPERATION, "glBindTexture(wrong dimensionality)" ); return; ... while it should refer to the target type (as the src code does). There is a problem in the FarCry, ver 1.4, which generates the following OpenGL calls sequence: glBindTexture(GL_TEXTURE_RECTANGLE_ARB,4326); ... glBindTexture(GL_TEXTURE_2D,4326); ... In this case, the texture dimensionality is the same.