Bug 16832

Summary: xorg-server: XDMCP related build error when --disable-xdmcp is used
Product: xorg Reporter: Juergen Beisert <juergen>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium CC: pebender
Version: gitKeywords: patch
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
patch to fix building without xdmcp none

Description Juergen Beisert 2008-07-24 01:00:06 UTC 
I'm not sure if I selected the right "Component" for this report. Hope "Core" is ok. When I try to build the xorg-server from git without XDMCP support, and without the XDMCP proto headers installed I get this compile error:

(Note: I do also crosscompiling)

../doltcompile i586-pmmx-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include   -isystem /home/jb/work/Entwicklung/repository/ptxdist-xorg-playground/sysroot-target/include -isystem /home/jb/work/Entwicklung/repository/ptxdist-xorg-playground/sysroot-target/usr/include -DHAVE_DIX_CONFIG_H -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -fno-strict-aliasing -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/home/jb/work/Entwicklung/repository/ptxdist-xorg-playground/sysroot-target/usr/include -I/home/jb/work/Entwicklung/repository/ptxdist-xorg-playground/sysroot-target/usr/include/pixman-1    -I../include -I../include -I../Xext  -I../damageext -I../xfixes -I../Xi -I../mi -I../miext/shadow  -I../miext/damage -I../render -I../randr -I../fb -g -O2 -c -o WaitFor.lo WaitFor.c

In file included from WaitFor.c:70:
osdep.h:59:23: error: X11/Xdmcp.h: No such file or directory
In file included from WaitFor.c:70:
osdep.h:117: error: expected ')' before 'Auth'
osdep.h:118: error: expected ')' before 'Auth'
In file included from WaitFor.c:70:
osdep.h:270: error: expected declaration specifiers or '...' before 'ValidatorFunc'
osdep.h:271: error: expected declaration specifiers or '...' before 'GeneratorFunc'
make[2]: *** [WaitFor.lo] Error 1
make[2]: Leaving directory `/home/jb/temp/xorg/xorg-server/os'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/jb/temp/xorg/xorg-server'

If the dependency to the XDMCP related packages does always exist, the configure script IMHO should also always test for their existance. My build environment (ptxdist) tries to solve all the dependencies, but I assumed a "--disable-xdmcp" does not need the XDMCP related packages to be built and installed prior compiling the xorg server. Maybe I'm wrong here.
Comment 1 Paul Bender 2009-06-30 15:50:46 UTC 
Created attachment 27279 [details] [review]
patch to fix building without xdmcp

I use the following patch to fix this problem. Hopefully it can be included in 1.6.x and git master so that I can get rid of the patch.
Comment 2 Alan Coopersmith 2009-08-03 21:00:12 UTC 
Patch pushed to git master.   To request it for future Xserver 1.6.* releases,
you can add it to the nomination list on http://www.x.org/wiki/Server16Branch

Thanks for the bug report & fix.

http://cgit.freedesktop.org/xorg/xserver/commit/?id=736f2d64725c6df8413e627bd40ce7ecb011acc7

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.