Bug 16470

Summary: Erroneous right click events on Gateway M285 tablet.
Product: xorg Reporter: Douglas Webster <thevirtualcat>
Component: Input/fpitAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED INVALID QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: low CC: jeremyhu
Version: gitKeywords: patch
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard: 2011BRB_Reviewed
i915 platform: i915 features:
Attachments:
Description Flags
Patch I used to fix the problem. none

Description Douglas Webster 2008-06-22 22:11:11 UTC
Created attachment 17313 [details] [review]
Patch I used to fix the problem.

Overview: Erroneous right click events on Gateway M285 tablet.

Steps to Reproduce: 

(Requires Gateway M285 tablet, may also happen on other, similar devices.)
(a) Use "setserial" to set up /dev/ttyS0 for 34800 baud.
(b) Install fpit-1.2 driver and add appropriate entries to xorg.conf. (Example follows.)

Section "InputDevice"
	Identifier	"Tablet"
	Driver		"fpit"
	Option		"Device"	"/dev/ttyS0"
	Option		"MaximumXPosition"	"12550"
	Option		"MaximumYPosition"	"7650"
	Option		"MinimumXPosition"	"400"
	Option		"MinimumYPosition"	"400"
	Option		"InvertY"
	Option		"Passive"	"false"
	Option		"TrackRandR"
	Option		"SendCoreEvents"	"true"
EndSection

(c) Restart X11
(d) Hover pen around the screen.

Expected Results:

Mouse pointer should follow pen around the screen. No click events should occur. (E/G: No context menu should pop up.)

Actual Results:

Mouse pointer follows pen around screen. Right click events are randomly generated. (Context menu pops up randomly.)

Build Date & Platform:

Ubuntu 8.04, 32-bit. Using the Ubuntu-intrepid source package.
http://packages.ubuntu.com/source/intrepid/xserver-xorg-input-fpit

Gateway M285 tablet PC. 

Additional Information:

As with most tablets, hovering the stylus over the screen should cause the mouse pointer to follow it. Tapping the screen should registers a left-click event. Tapping the screen while holding the button down on the side of the stylus should register a right-click event. (This is the minimum functionality. This is also how it functions in Windows, which is the operating system the machine ships with.)

As it is written now, on this specific tablet, hovering over the screen will cause right click events to register when they are not supposed to. (There should not be any click events registered while the pen is hovering.)

I have attached a diff of the change I made to fix the problem, but I'm sure I'm not the only one with this problem. Two things to note about it:
(a) I didn't write it. I found it here: http://www.linuxquestions.org/questions/linux-laptop-and-handheld-25/howto-get-your-gateway-or-finepoint-pen-working-497879/page6.html
(b) It may break other devices that work with the driver.

If something could be done to accommodate these devices in a future release, I would much appreciate it.
Comment 1 Jeremy Huddleston Sequoia 2011-10-17 01:00:57 UTC
Can you please send your patch to xorg-devel for review with your sign-off (git 
commit -s) and formatted by git (git format-patch HEAD^)
Comment 2 Adam Jackson 2018-06-12 19:06:57 UTC
Mass closure: This bug has been untouched for more than six years, and is not
obviously still valid. Please reopen this bug or file a new report if you continue to experience issues with current releases.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.