Bug 16133

Summary:	Mesa assumes that "make" is GNU make
Product:	Mesa	Reporter:	Coleman Kane <ckane>
Component:	GLX	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	git
Hardware:	All
OS:	FreeBSD
Whiteboard:
i915 platform:		i915 features:
Attachments:	Fixes the assumption that "make" is what the user is calling

Description Coleman Kane 2008-05-28 07:37:30 UTC

Created attachment 16788 [details] [review]
Fixes the assumption that "make" is what the user is calling

Mesa's Makefiles are built in the GNU-make style, and specifically the src/glx/x11/Makefile assumes that executing "make" executes GNU make. Instead of making the assumption, the proper thing to do is to use the $(MAKE) expansion wherever you want to call into the make program again. This has the benefit of always referring to the currently running "make" binary, rather than assuming that it is named "make".

On FreeBSD "gmake" is the proper make to use to build Mesa.

Comment 1 Brian Paul 2008-05-28 07:53:57 UTC

Fixed.  Thanks.

Comment 2 Dan Nicholson 2008-05-28 09:50:34 UTC

Brian, I think this needs to be backported to 7.1, too. Do you want to cut a mesa_7_1_branch or just keep tagging from master?

Also, it's currently implicit that you need GNU make to build mesa. I think we should just make it explicit. I.e., document it and put a check in the top level Makefile that $(MAKE) is GNU make and bomb if it's not. What do you think?

Comment 3 Brian Paul 2008-05-28 12:55:27 UTC

master==7.1 for a while longer.

AFAIK, gnu make is only needed for DRI builds.  Is that not true?

Comment 4 Dan Nicholson 2008-05-28 14:14:11 UTC

You might be right about that. If I find it's not, I'll bring it up again.

Comment 5 Adam Jackson 2009-08-24 12:30:15 UTC

Mass version move, cvs -> git

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.